Fixed test checking commission for non-EUR original currencies #8

Merged

inga-lovinde merged 6 commits from fix-6-non-eur-currencies into main 11 months ago

inga-lovinde commented 11 months ago

Owner

Closes #6, but it is not a long-term fix, and the code will still not work outside of tests because of #7.

inga-lovinde added 6 commits 11 months ago

279e5230e5 refactor: implemented async getExchangeRate method

ac7aabb7c4 refactor: rules now accept partial transaction object instead of TransactionInput

dcf34b6791 refactor: better types

296fdb4945 fix: use base_amount to calculate commission

dd5c719345 fix: declared return type on getExchangeRate

61d8b18c0a fix: divide by 'rate' instead of multiplying by it, so that tests pass

inga-lovinde merged commit bb14f3238e into main 11 months ago

inga-lovinde referenced this issue from a commit 11 months ago

Merge pull request 'Fixed test checking commission for non-EUR original currencies' (#8) from fix-6-non-eur-currencies into main

inga-lovinde deleted branch fix-6-non-eur-currencies 11 months ago

The pull request has been merged as bb14f3238e.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inga-lovinde/test-assignment-payments#8