Removed CodeAnalysisRuleSet setting

dependabot/npm_and_yarn/BuildServer/eslint-7.2.0
Inga 🏳‍🌈 9 years ago
parent b0dbfcf091
commit fccaf81287
  1. 8
      BuildServer/lib/tasks/dotnetcompile.js
  2. 2
      DotNetBuilder/CompileRequest.cs
  3. 2
      DotNetBuilder/Compiler.cs

@ -19,9 +19,13 @@ module.exports = function (params, processor) {
processor.done(); processor.done();
return; return;
} }
compileParams.SkipCodeAnalysis = true;
} else { } else {
if ((!settings.ignoreCodeAnalysisByDefault && !params.ignoreCodeAnalysis) || params.forceCodeAnalysis) { if (settings.ignoreCodeAnalysisByDefault && !params.forceCodeAnalysis) {
compileParams.CodeAnalysisRuleSet = settings.codeAnalysisRuleSet; compileParams.SkipCodeAnalysis = true;
}
if (params.ignoreCodeAnalysis) {
compileParams.SkipCodeAnalysis = true;
} }
} }
return dotnetbuilderwrapper(compileParams, processor); return dotnetbuilderwrapper(compileParams, processor);

@ -10,6 +10,6 @@
public string SigningKey { get; set; } public string SigningKey { get; set; }
public string CodeAnalysisRuleSet { get; set; } public bool SkipCodeAnalysis { get; set; }
} }
} }

@ -88,7 +88,7 @@ namespace MicroBuildServer.DotNetBuilder
globalProperty.Add("SignAssembly", "true"); globalProperty.Add("SignAssembly", "true");
globalProperty.Add("AssemblyOriginatorKeyFile", request.SigningKey); globalProperty.Add("AssemblyOriginatorKeyFile", request.SigningKey);
} }
if (!string.IsNullOrEmpty(request.CodeAnalysisRuleSet)) if (!request.SkipCodeAnalysis)
{ {
globalProperty.Add("RunCodeAnalysis", "true"); globalProperty.Add("RunCodeAnalysis", "true");
globalProperty.Add("CodeAnalysisRuleSet", Path.Combine(BuilderAssemblyDirectory, "AllRules.ruleset")); globalProperty.Add("CodeAnalysisRuleSet", Path.Combine(BuilderAssemblyDirectory, "AllRules.ruleset"));

Loading…
Cancel
Save