LoadByIds while in transaction implemented in DBConnection and SQLConnector

Core/DB/IDBConnection.cs

@@ -18,6 +18,8 @@ namespace FLocal.Core.DB {
 
 		void lockRow(Transaction transaction, ITableSpec table, string id);
 
+		List<Dictionary<string, string>> LoadByIds(Transaction transaction, ITableSpec table, List<string> ids);
+
 		void update(Transaction transaction, ITableSpec table, string id, Dictionary<string, string> data);
 
 		string insert(Transaction transaction, ITableSpec table, Dictionary<string, string> data);

MySQLConnector/Connection.cs

@@ -31,9 +31,7 @@ namespace FLocal.MySQLConnector {
 			return connection;
 		}
 
-		public List<Dictionary<string, string>> LoadByIds(ITableSpec table, List<string> ids) {
+		private List<Dictionary<string, string>> _LoadByIds(DbCommand command, ITableSpec table, List<string> ids, bool forUpdate) {
-			lock(this) {
-				using(DbCommand command = this.connection.CreateCommand()) {
 			command.CommandType = System.Data.CommandType.Text;
 
 			ParamsHolder paramsHolder = new ParamsHolder();
@@ -42,7 +40,7 @@ namespace FLocal.MySQLConnector {
 				placeholder.Add(this.traits.markParam(paramsHolder.Add(id)));
 			}
 
-					command.CommandText = "SELECT * FROM " + table.compile(this.traits) + " WHERE " + table.getIdSpec().compile(this.traits) + " IN (" + string.Join(", ", placeholder.ToArray()) + ")";
+			command.CommandText = "SELECT * FROM " + table.compile(this.traits) + " WHERE " + table.getIdSpec().compile(this.traits) + " IN (" + string.Join(", ", placeholder.ToArray()) + ")" + (forUpdate ? " FOR UPDATE" : "");
 			//command.Prepare();
 			foreach(KeyValuePair<string, string> kvp in paramsHolder.data) {
 				command.AddParameter(kvp.Key, kvp.Value);
@@ -75,6 +73,12 @@ namespace FLocal.MySQLConnector {
 			}
 			return result;
 		}
+
+		public List<Dictionary<string, string>> LoadByIds(ITableSpec table, List<string> ids) {
+			lock(this) {
+				using(DbCommand command = this.connection.CreateCommand()) {
+					return this._LoadByIds(command, table, ids, false);
+				}
 			}
 		}
 
@@ -209,6 +213,16 @@ namespace FLocal.MySQLConnector {
 			}
 		}
 
+		public List<Dictionary<string, string>> LoadByIds(FLocal.Core.DB.Transaction _transaction, ITableSpec table, List<string> ids) {
+			Transaction transaction = (Transaction)_transaction;
+			lock(transaction) {
+				using(DbCommand command = transaction.sqlconnection.CreateCommand()) {
+					command.Transaction = transaction.sqltransaction;
+					return this._LoadByIds(command, table, ids, true);
+				}
+			}
+		}
+
 		public void update(FLocal.Core.DB.Transaction _transaction, ITableSpec table, string id, Dictionary<string, string> data) {
 			Transaction transaction = (Transaction)_transaction;
 			lock(transaction) {