inga-lovinde
/
test-assignment-payments
1
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity
Labels Milestones
New Issue

Refactor exchange rate service to use promises instead of observables #9

Open
opened 4 months ago by inga-lovinde · 0 comments
inga-lovinde commented 4 months ago
Owner

Currently, ExchangeRateService.prototype.convertCurrency is implemented to return Observable<ExchangeRateResponse>, making it difficult and non-straighforward to use, while providing zero benefit (convertCurrency is only supposed to return one value anyway).

Better to refactor it into a standard async function. Doing it now does not make a lot of sense though, because it should be rewritten in #7 anyway.

Currently, `ExchangeRateService.prototype.convertCurrency` is implemented to return `Observable<ExchangeRateResponse>`, making it difficult and non-straighforward to use, while providing zero benefit (`convertCurrency` is only supposed to return one value anyway). Better to refactor it into a standard async function. Doing it now does not make a lot of sense though, because it should be rewritten in #7 anyway.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
interview
main
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: inga-lovinde/test-assignment-payments#9
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes