Labels Milestones

New Issue

Update applyRules to return the minimum commission instead of the first one #16

Closed

opened 11 months ago by inga-lovinde · 0 comments

inga-lovinde commented 11 months ago

Owner

According to documentation:

The lowest commission shall be used if there are multiple rules matching.

Yet applyRules returns the first non-zero commission.

According to documentation: > The **lowest** commission shall be used if there are **multiple** rules matching. Yet `applyRules` returns the first non-zero commission.

inga-lovinde referenced this issue from a commit 11 months ago

feat: fixed applyRules logic (closes #16)

inga-lovinde referenced a pull request that will close this issue 11 months ago

Implemented tests for rules; fixed applyRules logic #18

inga-lovinde closed this issue 11 months ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

interview

main

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: inga-lovinde/test-assignment-payments#16

Write Preview

Loading…

Cancel

Save

There is no content yet.