From 8a36b28fa79eee9e46de3efdae5c8f4831da0371 Mon Sep 17 00:00:00 2001
From: Inga <52715130+inga-lovinde@users.noreply.github.com>
Date: Mon, 11 Dec 2023 12:51:35 +0000
Subject: [PATCH] more clarifications

---
 solution.md | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/solution.md b/solution.md
index 7c9e852..42920fa 100644
--- a/solution.md
+++ b/solution.md
@@ -193,6 +193,9 @@ The code is mostly covered by tests.
 
 I did not have any time to come up with good test cases, so most tests work on samples of data from OMDB and on provided sample JSONs.
 
+Regular tests (ran with `npm test`) do not have any external dependencies.
+Additionally there are tests that connect to remote OMDB API; these are ran with `npm run test:e2e`.
+
 ## Git
 
 The assignment has two contradicting messages:
@@ -202,12 +205,14 @@ but also that you will evaluate the proper use of git.
 
 I decided to go with the first message, and use git to document work history, not to showcase git use that would be proper for PRs in a professional environment.
 
+## Configuration
+
+OMDB API token is passed to the app and e2e tests as an environment variable (hardcoded in package.json, but can easily be extracted from there).
+
 # How to use
 
 To start: `npm run start`; it is available on `localhost:3000` by default.
 
-To run tests: `npm test`.
-
-To run tests that connect to actual OMDB (these are not included in `npm test`): `npm run test:e2e`.
+To run tests: `npm test`, `npm run test:e2e` (see "Testing" section for more details).
 
-To lint: `npm run lint`.
\ No newline at end of file
+To lint: `npm run lint` (see "Framework" section for more details).