From 7bca2e50d6609eeb842a8b11a61c8c842ecf78ab Mon Sep 17 00:00:00 2001 From: Inga Lovinde <52715130+inga-lovinde@users.noreply.github.com> Date: Tue, 10 Dec 2013 14:21:22 +0400 Subject: [PATCH] Refactored conditional task; added "otherwise" support --- BuildServer/lib/tasks/conditional.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/BuildServer/lib/tasks/conditional.js b/BuildServer/lib/tasks/conditional.js index 2148f2e..bd2cb4e 100644 --- a/BuildServer/lib/tasks/conditional.js +++ b/BuildServer/lib/tasks/conditional.js @@ -1,17 +1,12 @@ "use strict"; module.exports = function (params, processor) { + var condition = (!params.owner || params.owner === processor.context.owner) && (!params.branch || params.branch === processor.context.branch || "refs/heads/" + params.branch === processor.context.branch), + task = condition ? params.task : params.otherwise; + return { process: function () { - if (params.owner && params.owner != processor.context.owner) { - return processor.done(); - } - - if (params.branch && params.branch != processor.context.branch) { - return processor.done(); - } - - processor.processTask(params.task, processor.done.bind(processor)); + return processor.processTask(task || {type: "noop"}, processor.done.bind(processor)); } }; };