Refactored MainHandler

RadeonResetBugFixService/MainHandler.cs

@@ -24,97 +24,17 @@
                 $"radeonfix_{date:yyyyMMdd}_{date:HHmmss}.log");
         }
 
-        public void HandleLog(string message)
-        {
-            using (ILogger fileLogger = new FileLogger(this.LogFilename))
-            {
-                fileLogger.Log(message);
-            }
-        }
-
-        public void HandleStartup(string reason)
-        {
-            using (var fileLogger = new FileLogger(this.LogFilename))
-            {
-                using (ILogger logger = new TaskLoggerWrapper(fileLogger, "Startup"))
-                {
-                    logger.Log($"Reason: {reason}");
-                    try
-                    {
-                        lock (this.Mutex)
-                        {
-                            TasksProcessor.ProcessTasks(
-                                logger,
-                                new ITask[]
-                                {
-                                    new EnableBasicDisplayStartupTask(),
-                                    new SleepTask(TimeSpan.FromSeconds(40)),
-                                    new EnableAmdVideoTask(this.StartupDevicesStatus),
-                                    new DisableVirtualVideoTask(this.StartupDevicesStatus),
-                                    new SleepTask(TimeSpan.FromSeconds(20)),
-                                    new FixMonitorTask(),
-                                    new DisableVirtualVideoTask(this.StartupDevicesStatus),
-                                    new FixMonitorTask(),
-                                });
-                        }
-                    }
-                    catch (Exception e)
-                    {
-                        logger.LogError(e.ToString());
-                    }
-                }
-            }
-        }
-
-        public void HandleShutdown(string reason)
-        {
-            using (var fileLogger = new FileLogger(this.LogFilename))
-            {
-                using (ILogger logger = new TaskLoggerWrapper(fileLogger, "Shutdown"))
-                {
-                    logger.Log($"Reason: {reason}");
-                    try
-                    {
-                        lock (this.Mutex)
-                        {
-                            TasksProcessor.ProcessTasks(
-                                logger,
-                                new ITask[]
-                                {
-                                    new StopAudioServiceTask(),
-                                    new EnableVirtualVideoTask(this.ShutdownDevicesStatus),
-                                    new DisableAmdVideoTask(this.ShutdownDevicesStatus),
-                                    new LastResortDevicesRestoreTask(this.StartupDevicesStatus),
-                                    new LastResortDevicesRestoreTask(this.StartupDevicesStatus), // just in case
-                                    new DisableBasicDisplayStartupTask(this.StartupDevicesStatus),
-                                });
-                        }
-                    }
-                    catch (Exception e)
-                    {
-                        logger.LogError(e.ToString());
-                    }
-                }
-            }
-        }
-
-        public void HandleDiagnose(string reason)
+        public void HandleEntryPoint(string name, Action<ILogger> handle)
         {
             using (var fileLogger = new FileLogger(this.LogFilename))
             {
-                using (ILogger logger = new TaskLoggerWrapper(fileLogger, "Diagnose"))
+                using (ILogger logger = new TaskLoggerWrapper(fileLogger, name))
                 {
-                    logger.Log($"Reason: {reason}");
                     try
                     {
                         lock (this.Mutex)
                         {
-                            TasksProcessor.ProcessTasks(
-                                logger,
-                                new ITask[]
-                                {
-                                    new ListDevicesTask(),
-                                });
+                            handle(logger);
                         }
                     }
                     catch (Exception e)

RadeonResetBugFixService/Program.cs

@@ -2,6 +2,7 @@
 {
     using System;
     using System.ServiceProcess;
+    using Tasks.ComplexTasks;
     using ThirdParty.ServiceHelpers;
 
     public static class Program
@@ -133,19 +134,19 @@
             DoInstall();
         }
 
-        private static void DoStartup()
-        {
-            new MainHandler().HandleStartup("Program.DoStartup");
-        }
+        private static void DoStartup() => new MainHandler().HandleEntryPoint(
+            "Program.DoStartup",
+            (logger) => TasksProcessor.ProcessTask(logger, new StartupTask())
+        );
 
-        private static void DoShutdown()
-        {
-            new MainHandler().HandleShutdown("Program.DoShutdown");
-        }
+        private static void DoShutdown() => new MainHandler().HandleEntryPoint(
+            "Program.DoShutdown",
+            (logger) => TasksProcessor.ProcessTask(logger, new ShutdownTask())
+        );
 
-        private static void DoDiagnose()
-        {
-            new MainHandler().HandleDiagnose("Program.DoDiagnose");
-        }
+        private static void DoDiagnose() => new MainHandler().HandleEntryPoint(
+            "Program.DoDiagnose",
+            (logger) => TasksProcessor.ProcessTask(logger, new DiagnoseTask())
+        );
     }
 }

RadeonResetBugFixService/RadeonResetBugFixService.cs

@@ -4,6 +4,7 @@
     using System.Reflection;
     using System.ServiceProcess;
     using Microsoft.Win32;
+    using Tasks.ComplexTasks;
 
     public partial class RadeonResetBugFixService : ServiceBase
     {
@@ -35,38 +36,22 @@
             deferredStopMethodInfo.Invoke(this, null);
         }
 
-        private void Process(string reason, Action<string> handle)
-        {
-            this.Handler.HandleLog($"{reason} initiated");
-            try
-            {
-                handle(reason);
-                this.Handler.HandleLog($"{reason} successfully finished");
-            }
-            catch (Exception e)
-            {
-                this.Handler.HandleLog($"{reason} error: {e}");
-            }
-        }
-
         protected override void OnShutdown()
         {
-            this.Process(
+            this.Handler.HandleEntryPoint(
                 "ServiceBase.OnShutdown",
-                (string reason) =>
-                {
-                    this.CallStop();
-                });
+                (logger) => this.CallStop()
+            );
         }
 
         protected override void OnStart(string[] args)
         {
-            this.Process(
+            this.Handler.HandleEntryPoint(
                 "ServiceBase.OnStart",
-                (string reason) =>
+                (logger) =>
                 {
                     this.RequestAdditionalTime((int)Constants.ServiceTimeout.TotalMilliseconds);
-                    this.Handler.HandleStartup(reason);
+                    TasksProcessor.ProcessTask(logger, new StartupTask());
                     this.EnablePreshutdown();
                     SystemEvents.SessionEnding += this.OnSessionEnding;
                 });
@@ -74,12 +59,12 @@
 
         protected override void OnStop()
         {
-            this.Process(
+            this.Handler.HandleEntryPoint(
                 "ServiceBase.OnStop",
-                (string reason) =>
+                (logger) =>
                 {
                     this.RequestAdditionalTime((int)Constants.ServiceTimeout.TotalMilliseconds);
-                    this.Handler.HandleShutdown(reason);
+                    TasksProcessor.ProcessTask(logger, new ShutdownTask());
                     SystemEvents.SessionEnding -= this.OnSessionEnding;
                 });
         }
@@ -88,33 +73,33 @@
         {
             const int SERVICE_CONTROL_PRESHUTDOWN = 0xf;
 
-            this.Process(
+            this.Handler.HandleEntryPoint(
                 "ServiceBase.OnCustomCommand",
-                (string reason) =>
+                (logger) =>
                 {
                     if (command == SERVICE_CONTROL_PRESHUTDOWN)
                     {
-                        this.Handler.HandleLog($"Custom command: preshutdown");
+                        logger.Log("Custom command: preshutdown");
                         this.CallStop();
                     }
                     else
                     {
-                        this.Handler.HandleLog($"Unknown custom command: {command}");
+                        logger.Log("Unknown custom command: {command}");
                     }
                 });
         }
 
         private void OnSessionEnding(object sender, SessionEndingEventArgs args)
         {
-            this.Process(
+            this.Handler.HandleEntryPoint(
                 "SystemEvents.OnSessionEnding",
-                (string reason) =>
+                (logger) =>
                 {
-                    this.Handler.HandleLog($"Session end reason: ${args.Reason}");
+                    logger.Log($"Session end reason: ${args.Reason}");
 
                     if (args.Reason == SessionEndReasons.SystemShutdown)
                     {
-                        this.Handler.HandleShutdown(reason);
+                        TasksProcessor.ProcessTask(logger, new ShutdownTask());
                     }
                 });
         }

RadeonResetBugFixService/RadeonResetBugFixService.csproj

@@ -85,23 +85,27 @@
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Logging\TaskLoggerWrapper.cs" />
     <Compile Include="RegistryHelper.cs" />
-    <Compile Include="Tasks\DisableBasicDisplayStartupTask.cs" />
-    <Compile Include="Tasks\EnableBasicDisplayStartupTask.cs" />
-    <Compile Include="Tasks\FixMonitorTask.cs" />
-    <Compile Include="Tasks\LastResortDevicesRestoreTask.cs" />
-    <Compile Include="Tasks\ListDevicesTask.cs" />
-    <Compile Include="Tasks\SleepTask.cs" />
+    <Compile Include="Tasks\BasicTasks\DisableBasicDisplayStartupTask.cs" />
+    <Compile Include="Tasks\BasicTasks\EnableBasicDisplayStartupTask.cs" />
+    <Compile Include="Tasks\BasicTasks\FixMonitorTask.cs" />
+    <Compile Include="Tasks\BasicTasks\LastResortDevicesRestoreTask.cs" />
+    <Compile Include="Tasks\BasicTasks\ListDevicesTask.cs" />
+    <Compile Include="Tasks\BasicTasks\SleepTask.cs" />
+    <Compile Include="Tasks\ComplexTasks\AbstractSequentialTask.cs" />
+    <Compile Include="Tasks\ComplexTasks\DiagnoseTask.cs" />
+    <Compile Include="Tasks\ComplexTasks\ShutdownTask.cs" />
+    <Compile Include="Tasks\ComplexTasks\StartupTask.cs" />
     <Compile Include="ThirdParty\MonitorChanger.cs" />
     <Compile Include="ThirdParty\ServiceHelpers.cs" />
     <Compile Include="TasksProcessor.cs" />
-    <Compile Include="Tasks\AbstractDevicesTask.cs" />
-    <Compile Include="Tasks\AbstractServiceTask.cs" />
-    <Compile Include="Tasks\DisableAmdVideoTask.cs" />
-    <Compile Include="Tasks\DisableVirtualVideoTask.cs" />
-    <Compile Include="Tasks\EnableAmdVideoTask.cs" />
-    <Compile Include="Tasks\EnableVirtualVideoTask.cs" />
+    <Compile Include="Tasks\BasicTasks\AbstractDevicesTask.cs" />
+    <Compile Include="Tasks\BasicTasks\AbstractServiceTask.cs" />
+    <Compile Include="Tasks\BasicTasks\DisableAmdVideoTask.cs" />
+    <Compile Include="Tasks\BasicTasks\DisableVirtualVideoTask.cs" />
+    <Compile Include="Tasks\BasicTasks\EnableAmdVideoTask.cs" />
+    <Compile Include="Tasks\BasicTasks\EnableVirtualVideoTask.cs" />
     <Compile Include="Tasks\ITask.cs" />
-    <Compile Include="Tasks\StopAudioServiceTask.cs" />
+    <Compile Include="Tasks\BasicTasks\StopAudioServiceTask.cs" />
     <Compile Include="ThirdParty\DisableDevice.cs" />
     <Compile Include="Devices\DeviceHelper.cs" />
     <Compile Include="ThirdParty\ServicePreshutdownHelpers.cs" />
@@ -131,6 +135,7 @@
     <Analyzer Include="..\packages\Microsoft.NetFramework.Analyzers.2.9.8\analyzers\dotnet\cs\Microsoft.NetFramework.Analyzers.dll" />
     <Analyzer Include="..\packages\Microsoft.NetFramework.Analyzers.2.9.8\analyzers\dotnet\cs\Microsoft.NetFramework.CSharp.Analyzers.dll" />
   </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
     <PropertyGroup>

RadeonResetBugFixService/Tasks/BasicTasks/AbstractDevicesTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using System.Linq;

RadeonResetBugFixService/Tasks/BasicTasks/AbstractServiceTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using System.ServiceProcess;

RadeonResetBugFixService/Tasks/BasicTasks/DisableAmdVideoTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using Contracts;
     using Devices;

RadeonResetBugFixService/Tasks/BasicTasks/DisableBasicDisplayStartupTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using Contracts;

RadeonResetBugFixService/Tasks/BasicTasks/DisableVirtualVideoTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using Contracts;
     using Devices;

RadeonResetBugFixService/Tasks/BasicTasks/EnableAmdVideoTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using Contracts;
     using Devices;

RadeonResetBugFixService/Tasks/BasicTasks/EnableBasicDisplayStartupTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using Contracts;
 

RadeonResetBugFixService/Tasks/BasicTasks/EnableVirtualVideoTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using Contracts;
     using Devices;

RadeonResetBugFixService/Tasks/BasicTasks/FixMonitorTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using System.Collections.Generic;

RadeonResetBugFixService/Tasks/BasicTasks/LastResortDevicesRestoreTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using Contracts;

RadeonResetBugFixService/Tasks/BasicTasks/ListDevicesTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System.Linq;
     using Contracts;

RadeonResetBugFixService/Tasks/BasicTasks/SleepTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using System.Threading;

RadeonResetBugFixService/Tasks/BasicTasks/StopAudioServiceTask.cs

@@ -1,4 +1,4 @@
-namespace RadeonResetBugFixService.Tasks
+namespace RadeonResetBugFixService.Tasks.BasicTasks
 {
     using System;
     using System.ServiceProcess;

RadeonResetBugFixService/Tasks/ComplexTasks/AbstractSequentialTask.cs

@@ -0,0 +1,13 @@
+namespace RadeonResetBugFixService.Tasks.ComplexTasks
+{
+    using Contracts;
+
+    abstract class AbstractSequentialTask : ITask
+    {
+        public abstract string TaskName { get; }
+
+        protected abstract ITask[] Subtasks { get; }
+
+        void ITask.Run(ILogger logger) => TasksProcessor.ProcessTasks(logger, this.Subtasks);
+    }
+}

RadeonResetBugFixService/Tasks/ComplexTasks/DiagnoseTask.cs

@@ -0,0 +1,16 @@
+namespace RadeonResetBugFixService.Tasks.ComplexTasks
+{
+    using BasicTasks;
+    using Contracts;
+    using System;
+
+    class DiagnoseTask : AbstractSequentialTask
+    {
+        public override string TaskName => "Diagnose";
+
+        protected override ITask[] Subtasks => new ITask[]
+        {
+            new ListDevicesTask(),
+        };
+    }
+}

RadeonResetBugFixService/Tasks/ComplexTasks/ShutdownTask.cs

@@ -0,0 +1,25 @@
+namespace RadeonResetBugFixService.Tasks.ComplexTasks
+{
+    using BasicTasks;
+    using Contracts;
+    using System;
+
+    class ShutdownTask : AbstractSequentialTask
+    {
+        private DevicesStatus ShutdownDevicesStatus { get; } = new DevicesStatus();
+
+        public override string TaskName => "Shutdown";
+
+        protected override ITask[] Subtasks => new ITask[]
+        {
+            new EnableBasicDisplayStartupTask(),
+            new SleepTask(TimeSpan.FromSeconds(40)),
+            new EnableAmdVideoTask(this.ShutdownDevicesStatus),
+            new DisableVirtualVideoTask(this.ShutdownDevicesStatus),
+            new SleepTask(TimeSpan.FromSeconds(20)),
+            new FixMonitorTask(),
+            new DisableVirtualVideoTask(this.ShutdownDevicesStatus),
+            new FixMonitorTask()
+        };
+    }
+}

RadeonResetBugFixService/Tasks/ComplexTasks/StartupTask.cs

@@ -0,0 +1,25 @@
+namespace RadeonResetBugFixService.Tasks.ComplexTasks
+{
+    using BasicTasks;
+    using Contracts;
+    using System;
+
+    class StartupTask : AbstractSequentialTask
+    {
+        private DevicesStatus StartupDevicesStatus { get; } = new DevicesStatus();
+
+        public override string TaskName => "Startup";
+
+        protected override ITask[] Subtasks => new ITask[]
+        {
+            new EnableBasicDisplayStartupTask(),
+            new SleepTask(TimeSpan.FromSeconds(40)),
+            new EnableAmdVideoTask(this.StartupDevicesStatus),
+            new DisableVirtualVideoTask(this.StartupDevicesStatus),
+            new SleepTask(TimeSpan.FromSeconds(20)),
+            new FixMonitorTask(),
+            new DisableVirtualVideoTask(this.StartupDevicesStatus),
+            new FixMonitorTask()
+        };
+    }
+}

RadeonResetBugFixService/TasksProcessor.cs

@@ -8,7 +8,7 @@
 
     static class TasksProcessor
     {
-        private static void ProcessTask(ILogger logger, ITask task)
+        public static void ProcessTask(ILogger logger, ITask task)
         {
             using (ILogger taskLogger = new TaskLoggerWrapper(logger, task.TaskName))
             {